Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input coverage-reporter-version isn't recognized. #225

Closed
ConsoleCatzirl opened this issue Oct 2, 2024 · 9 comments · Fixed by #229
Closed

Input coverage-reporter-version isn't recognized. #225

ConsoleCatzirl opened this issue Oct 2, 2024 · 9 comments · Fixed by #229

Comments

@ConsoleCatzirl
Copy link

Setting coverage-reporter-version has no effect other than a warning that the input isn't recognized:

Warning: Unexpected input(s) 'coverage-reporter-version', valid inputs are ['github-token', 'path-to-lcov', 'file', 'files', 'format', 'flag-name', 'parallel', 'parallel-finished', 'carryforward', 'coveralls-endpoint', 'allow-empty', 'base-path', 'git-branch', 'git-commit', 'compare-ref', 'compare-sha', 'debug', 'measure', 'fail-on-error']
Run coverallsapp/github-action@v[2](https://github.com/Sage-Bionetworks-IT/cfn-explode-macro/actions/runs/11148235826/job/30984406533#step:8:2)
  with:
    coverage-reporter-version: v0.6.14
    file: coverage.lcov
    fail-on-error: false
    github-token: ***
    coveralls-endpoint: https://coveralls.io
    allow-empty: false
    debug: false
    measure: false
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/Sage-Bionetworks-IT/cfn-explode-macro/actions/runs/11148235826/job/30984406533#step:8:3).9.20/x6[4](https://github.com/Sage-Bionetworks-IT/cfn-explode-macro/actions/runs/11148235826/job/30984406533#step:8:4)
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.20/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.20/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.20/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.20/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.20/x64/lib
Run mkdir -p ~/bin/
  mkdir -p ~/bin/
  cd ~/bin/
  curl -sLO https://github.com/coverallsapp/coverage-reporter/releases/latest/download/coveralls-linux.tar.gz
  curl -sLO https://github.com/coverallsapp/coverage-reporter/releases/latest/download/coveralls-checksums.txt
  cat coveralls-checksums.txt | grep coveralls-linux.tar.gz | sha2[5](https://github.com/Sage-Bionetworks-IT/cfn-explode-macro/actions/runs/11148235826/job/30984406533#step:8:5)6sum --check
  tar -xzf coveralls-linux.tar.gz
@afinetooth
Copy link
Member

@jesusaurus Thanks for reporting. Looking into it. Will update you here.

@afinetooth
Copy link
Member

afinetooth commented Oct 2, 2024

Hi @jesusaurus.

It looks like that input option is present in the latest version of the github-action (v2.3.0).. You can see the input defined on lines 69-72 of the action.yml file on main.

However per this conditional, that input option is not available on MacOS runners, so if your runner was MacOS you would see the error message:

The coverage-reporter-version parameter is not available on macOS

But that's not what you're seeing, so I'm thinking you may be referencing an older version of the github-action?

Are you referencing a version older than v2.3.0, such as?:

coverallsapp/[email protected]

The @v2 version label should get you the latest version, which is v2.3.0:

coverallsapp/github-action@v2

@ConsoleCatzirl
Copy link
Author

ConsoleCatzirl commented Oct 2, 2024

@afinetooth thanks for the quick response, I'm currently using coverallsapp/github-action@v2, and thanks for confirming that it pulls the latest 2.x version, I was starting to wonder about that. This is running on the ubuntu-latest Github runner, it looks like the exact version is Ubuntu 22.04.5, I hope that helps.

@afinetooth
Copy link
Member

@jesusaurus OK, got it. Likewise, thanks for confirming your usage of @v2.

In that case, it does seem like a bug. We'll have a deeper look and I'll get back to you asap.

@afinetooth
Copy link
Member

afinetooth commented Oct 15, 2024

@jesusaurus, I made some changes to the logic handling coverage-reporter-version that I hope will address your issue in this new release of the github-action (v2.3.2).

TBH, I was not able to account for what caused that error in your CI run, since, at that point, v2.3.0 should have recognized the new coverage-reporter-version input, and I was never able to reproduce the issue in my tests; but I suspect that this contemporaneous error with coverage-reporter v0.6.15 may have had something to do with it.

When you get a chance to try the coverage-reporter-version input again, I would love to hear how it worked for you.

@ConsoleCatzirl
Copy link
Author

@afinetooth thanks for looking into this. Still no change when using coverallsapp/github-action@v2, so I tried using coverallsapp/[email protected] explicitly, and that seems to have fixed my issue. I guess the v2 version isn't being updated.

(P.S. I changed my username)

@afinetooth
Copy link
Member

afinetooth commented Oct 16, 2024

@ConsoleCatzirl

This should be fixed now.

I think the real underlying issue was this:
#222

We had fallen out of our standard pattern for releases such that our floating tag v2 was not pointing to our latest release. v2 should now point to latest version (currently, v2.3.3)

Can you please try again and let me know if it's not working as expected for you? 🙏

I'll close this until I hear otherwise from you. Thanks.

@ConsoleCatzirl
Copy link
Author

@afinetooth awesome! v2 is working as expected now, thanks!

@afinetooth
Copy link
Member

Perfect. Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants