Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

GitHub icon is not visible in dark mode in the Footer of the About section #2252

Closed
lopeselio opened this issue Jul 18, 2020 · 2 comments
Closed

Comments

@lopeselio
Copy link

Describe the bug
GitHub icon is not visible in dark mode in the Footer of the About section
A clear and concise description of what the bug is. If your issue is regarding an error in the data, it's best reported through this form.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://www.covid19india.org/about'
  2. Switch to dark mode
  3. Scroll down to the footer below
  4. See error - GitHub icon is not visible in dark mode in the Footer of the About section

Expected behavior
As soon as switching the page to dark mode, the color of all footer icons should also change to enhance visibility. The black github logo is not visible in the dark mode. Most users prefer dark mode, especially at night, since dark mode has become a trend nowadays. Developers willing to contribute to the project will find it difficult to locate the link to the github repo.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Linux Mint 19.3]
  • Browser [e.g. chrome, safari]
  • Version [ 84.0.4147.89 (Official Build) (64-bit]

Smartphone (please complete the following information):

  • Device: [e.g. OPPO f11 Pro]
  • OS: [e.g. Android]
  • Browser [e.g. Google Chrome]
  • Version [ 84.0.4147.89 (Official Build) (64-bit]

Additional context
Tweaks
githubicon
for dark mode
https://css-tricks.com/dark-mode-favicons/
`

<style> circle { fill: yellow; stroke: black; stroke-width: 3px; } @media (prefers-color-scheme: dark) { circle { fill: black; stroke: yellow; } } </style> `
@bijankundu
Copy link

bijankundu commented Jul 18, 2020

@balrajsingh9 has fixed it in #2180 and duplicate of #2209 and #2246

@shuklaayush
Copy link
Member

Fixed via 1a707d4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants