Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Ids for tests #527

Open
colbymorrison opened this issue Aug 19, 2020 · 0 comments
Open

Unique Ids for tests #527

colbymorrison opened this issue Aug 19, 2020 · 0 comments
Labels
maintenance Code maintenance tasks, such as refactoring

Comments

@colbymorrison
Copy link
Contributor

The frontend tests simulate, say, entering an input by finding the id of the input and simulating a change. For example, this test finds the second "new-password" id in the DOM and simulates inputting text there.

DeepinScreenshot_select-area_20200818230907

However, if another "new-password" ID is added, the input will no longer be the second "new-password" ID, it might now be the third. So the test would fail.

So, we should have components that are targeted by tests have unique IDs for the test to be picked out by the test.

@colbymorrison colbymorrison added the maintenance Code maintenance tasks, such as refactoring label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance tasks, such as refactoring
Projects
None yet
Development

No branches or pull requests

1 participant