Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Labels can only be added, never removed #289

Open
Phyks opened this issue Sep 13, 2016 · 8 comments
Open

Labels can only be added, never removed #289

Phyks opened this issue Sep 13, 2016 · 8 comments
Labels

Comments

@Phyks
Copy link

Phyks commented Sep 13, 2016

Hi,

I have some empty labels in my contact apps, but it seems they cannot be removed. Would be really cool if there was a way to remove empty labels.

Thanks

EDIT: Actually, this might be a duplicate of cozy/cozy-contacts#290 as a forced restart of the app clears empty labels.

@clochix clochix added the bug label Sep 14, 2016
@clochix
Copy link
Contributor

clochix commented Sep 14, 2016

Thanks for reporting @Phyks,

Could you describe the steps to reproduce this issue?

I have a contact with some specific labels. When I edit it and uncheck the labels, they disappear from the dropdown list but not from the contact popup. As soon as I close the popup, this labels disappear from the left menu.

@Phyks
Copy link
Author

Phyks commented Sep 14, 2016

Ok, here are some steps to reproduce it.

  • Take any contact and add it a new label, say "foobar". You get
    capture d ecran 2016-09-14 a 14 48 32
  • Uncheck the "foobar" label. The "foobar" label is now empty, and is still there in the dropdown. That's ok, and here's the matching screenshot.

capture d ecran 2016-09-14 a 14 50 06

- Now, close the contact popover. Foobar label is still empty, and still appears on the left hand side, in the tags list. However, it is empty, and should no longer be there I think. See screenshot

capture d ecran 2016-09-14 a 14 52 20

@clochix
Copy link
Contributor

clochix commented Sep 19, 2016

Thanks, I was able to reproduce. This only happens if app was not reloaded after label creation.
Also, when creating a new label, it's added at the top in the left menu, and not in the correct sort order.

Thanks for reporting!

@Phyks
Copy link
Author

Phyks commented Sep 19, 2016

Thanks for investigating it further :)

@Phyks
Copy link
Author

Phyks commented Sep 19, 2016

@clochix btw, I checked and labels seem to never be sorted (alphabetically at least). Where are they supposed to be sorted?

@Phyks
Copy link
Author

Phyks commented Sep 19, 2016

Also, it may be somehow linked to cozy/cozy-contacts#174.

@clochix
Copy link
Contributor

clochix commented Sep 20, 2016

I don't know where labels are supposed to be sorted, but, this is what I see in the UI: after adding a label and reloading the page, the labels are alphabetically sorted.

@Phyks
Copy link
Author

Phyks commented Sep 20, 2016

Indeed, labels are sorted after a full page refresh, my bad :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants