Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent update broke metayml_has_repository_resource test #56

Open
karenetheridge opened this issue Jul 9, 2014 · 5 comments
Open

recent update broke metayml_has_repository_resource test #56

karenetheridge opened this issue Jul 9, 2014 · 5 comments

Comments

@karenetheridge
Copy link

My author page now shows failures in all dists for metayml_has_repository_resource.

@jandrew
Copy link

jandrew commented Jul 14, 2014

I have that failure too. It caused me to fix some poorly written links, but the resource => repository option has always been in my META.yml file.

@karenetheridge
Copy link
Author

@charsbar
Copy link
Contributor

Sorry for the mess. As I wrote in the RT ticket, I pushed broken WIP code into production by mistake. Now the typo in the code is fixed and CPANTS databases have been regenerated. Thus this issue is almost gone.

However, it looks like there's still something to fix, for example to accept Repository key for META <= 1.4 (found in http://cpants.cpanauthors.org/dist/WWW-Mechanize-1.73). repository key is defined as an official key in CPAN::Meta::Validator, and synopsis in META spec (http://module-build.sourceforge.net/META-spec-v1.4.html#resources) implies that either, but it's not listed as one of the official keys in the description below. So probably it'd be better to accept this variation.

For the time being, the metric is moved from extra to experimental.

@karenetheridge
Copy link
Author

On Mon, Jul 14, 2014 at 05:10:13PM -0700, Kenichi Ishigaki wrote:

Sorry for the mess. As I wrote in the RT ticket, I pushed broken WIP code into production by mistake. Now the typo in the code is fixed and CPANTS databases have been regenerated. Thus this issue is almost gone.

Thank you!

However, it looks like there's still something to fix, for example to accept Repository key for META <= 1.4 (found in http://cpants.cpanauthors.org/dist/WWW-Mechanize-1.73). repository key is defined as an official key in CPAN::Meta::Validator, and synopsis in META spec (http://module-build.sourceforge.net/META-spec-v1.4.html#resources) implies that either, but it's not listed as one of the official keys in the description below. So probably it'd be better to accept this variation.

For the time being, the metric is moved from extra to experimental.

Do you mean 'Repository' capitalized, vs 'repository', lower-cased?
The v1.4 specification says that "extra" keys may start with upper case.
The v2 specification says that keys must match exactly, including case
(mixed case is not permitted).

Therefore, I think you could accept 'Repository' in v1.4 (META.yml), but not v2 (META.json).

@charsbar
Copy link
Contributor

Do you mean 'Repository' capitalized, vs 'repository', lower-cased?
The v1.4 specification says that "extra" keys may start with upper case.
The v2 specification says that keys must match exactly, including case
(mixed case is not permitted).

Therefore, I think you could accept 'Repository' in v1.4 (META.yml), but not v2 (META.json).

Thanks! I always forget I also need to cope with v2 (I probably need to fix how to store META stuff in the MCA stash).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants