Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What red color means? #309

Open
ghost opened this issue Apr 20, 2017 · 11 comments
Open

What red color means? #309

ghost opened this issue Apr 20, 2017 · 11 comments

Comments

@ghost
Copy link

ghost commented Apr 20, 2017

Some GUI elements are highlighted with red color. Is it just a decoration or a warning that something is wrong?

@roman380
Copy link
Collaborator

roman380 commented Apr 20, 2017

Any screenshot?

There is certain colorification to help identify filter/connection types

// filter colors
const COLORREF RenderParameters::color_filter_border_light = RGB(255, 255, 255);
const COLORREF RenderParameters::color_filter_border_dark = RGB(128, 128, 128);
const COLORREF RenderParameters::color_filter_type[4] = {
    RGB(192,192,192), // Filter::FILTER_UNKNOWN
    RGB(192,192,255), // Filter::FILTER_STANDARD
    RGB(255,128,0), // Filter::FILTER_WDM
    RGB(0,192,64)   // Filter::FILTER_DMO
};

const COLORREF RenderParameters::color_connection_break = RGB(192,0,0);
const COLORREF RenderParameters::color_connection_type[6] = {
    RGB(255,0,128),     // PIN_CONNECTION_TYPE_OTHER
    RGB(0,0,0),         // PIN_CONNECTION_TYPE_STREAM
    RGB(0,128,128),     // PIN_CONNECTION_TYPE_AUDIO
    RGB(0,128,0),       // PIN_CONNECTION_TYPE_VIDEO
    RGB(255,128,0),      // PIN_CONNECTION_TYPE_SUBTITLE
    RGB(128,64,128)     // PIN_CONNECTION_TYPE_MIXED
};

@mikecopperwhite
Copy link
Collaborator

There is also a red-orange highlight in the filters dialog when using search box.

@ghost
Copy link
Author

ghost commented Apr 20, 2017

Colorization of filters is understandable. But what is this:

default

@ghost
Copy link
Author

ghost commented Apr 20, 2017

Or this
default

@roman380
Copy link
Collaborator

It's just a decoration. Like red in GraphStudioNext icon it is not supposed to be an alert. No worries.

@cplussharp
Copy link
Owner

cplussharp commented Apr 20, 2017

The red decoration header of a property pages is to identify that this pages is implemented in graphstudionext. For some pin/filter interfaces graphstudionext has own property pages so the user can test this interface. In the original graphstudio these pages had a blue header, with the fork, this color was changed to red.

"PNP" are filters from Plug and Play devices, like a capture box or stick like in your example. The color in the filters dialog represents filter type or red if the filter dll is missing.

@ghost
Copy link
Author

ghost commented Apr 20, 2017

Ok, I got it about property pages. I didn't understand the answer about the filter insert dialog. This is red, because I have PNP filters?
default

Btw, what exclamation mark means :)?

@roman380
Copy link
Collaborator

roman380 commented Apr 20, 2017

Btw, what exclamation mark means :)?

Filter registration information is present, however the DLL file with the implementation is no longer available (esp. incorrect deinstallation of the COM server).

It might so happen (looking at the screenshot above) that for DMOs it reports incorrect information.

@cplussharp
Copy link
Owner

cplussharp commented Apr 20, 2017

Plug&Play Filters are purple. As roman said, the red exclamation mark means that the dll-file was not found.

But there seems to be a problem finding the dll file of the DMOs, when you filter for "(ALL) DirectShow Filters". If you switch to "(ALL) DMO Filters" the dll files are found.

@ghost
Copy link
Author

ghost commented Apr 20, 2017

Thank you, it's much more clear now. Great program, btw, I love it.

So the area with comboxes I outlined in the screenshot is red because of the missing DLLs or something else? Or it's a decoration :).

@mirh
Copy link

mirh commented Apr 21, 2017

Filter registration information is present, however the DLL file with the implementation is no longer available

Cool to know.
Would it be possible to implement a "pop-up info box" when you hover mouse arrow over the exclamation mark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants