Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running two pace progress bars, duplicates info on second #7

Open
rkoberg opened this issue Feb 10, 2015 · 2 comments
Open

running two pace progress bars, duplicates info on second #7

rkoberg opened this issue Feb 10, 2015 · 2 comments

Comments

@rkoberg
Copy link

rkoberg commented Feb 10, 2015

See screen grab. The first progress bar completes when it gets to the constructed total. The second one has duplicates progress data.
(this time with correct screen grab)
screen shot 2015-02-10 at 10 39 40 am

@monolithed
Copy link

+1

img-2015-07-26-15-42-54

@ahmadassaf
Copy link

If you have multiple instances of pace running in various parts of your application, from the second run onwards you might notice that the progress bar is not rendered correctly with duplicate output.
This effect is additive for each time pace is required with the same stream.

Cause: The problem is with pace dependency charm. In node.js 0.10 the EventEmitter constructor explicitly initializes this._events, so going Charm.prototype = new Stream; causes all Charm instances to share the same _events property.

Fix: Change the charm main module file index.js and replace Charm.prototype = new Stream; with Charm.prototype = Stream.prototype;

check my fork at:https://github.com/ahmadassaf/Awesome-Progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants