Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot npm install packages that were pushed on a custom domain repository (401 Unauthorized) #97

Open
snajjar opened this issue Nov 20, 2017 · 1 comment

Comments

@snajjar
Copy link

snajjar commented Nov 20, 2017

This is a (Bug Report / Feature Proposal)

Bug report

Description

Okay, I think i finally sorted this out.
If you create a repository then operate a custom domain on it, it seems that packages you push on it (using the custom domain url) will give a 401 error when pulled later on (through npm install/yarn add)

Additional Data

Removing the "authorizer: authorizerGithub" on the target.default handler will remove auth checking from the lambda function. It seems to work correctly after that.
But well, as a drawback everyone can now install your packages given the registry and name.

  • NPM CLI version you are using: npm 5.5.1, yarn 1.3.2
  • Serverless version you're using: 1.24.1
  • Node version you're using: 8.9.1
@snajjar snajjar changed the title Published package can't be installed with yarn Cannot npm install / yarn add packages that contains .css files Nov 20, 2017
@snajjar snajjar changed the title Cannot npm install / yarn add packages that contains .css files Cannot npm install packages that were pushed on a custom domain repository Nov 21, 2017
@snajjar snajjar changed the title Cannot npm install packages that were pushed on a custom domain repository Cannot npm install packages that were pushed on a custom domain repository (401 Unauthorized) Nov 21, 2017
@bandesz
Copy link

bandesz commented Feb 4, 2018

@snajjar I had the same issue and you have to run the command listed here: https://github.com/craftship/codebox-npm#custom-domain. What you are missing is that this command changes the apiEndpoint environment variable on the codebox-npm-${stage}-put Lambda function. You can do it manually if needed.

Also I looked into the code and if you don't have the stage name on your custom domain (so customdomain.com instead of e.g. customdomain.com/prod), then the command is probably going to set the apiEndpoint wrongly, so you have to correct it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants