Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike streaming JSON for crc setup. #2935

Closed
Tracked by #3014
gbraad opened this issue Jan 11, 2022 · 5 comments
Closed
Tracked by #3014

Spike streaming JSON for crc setup. #2935

gbraad opened this issue Jan 11, 2022 · 5 comments
Assignees
@anjannath
Labels
kind/spike Investigation to provide direction and workable tasks priority/major status/stale Issue went stale; did not receive attention or no reply from the OP

Comments

@gbraad
Copy link
Contributor

gbraad commented Jan 11, 2022 •
edited
Loading

When running crc setup information is streamed using stdout and only the end result is shown. This currently causes confusion, as messages like #2969 are shown; you can now run 'crc start' to start. This would direct a UI user to issue an unnecessary command from a command line.

It would be best to return the preflight and fixes from crc setup as a stream of JSON fragments, that can be interpreted by the tray/app and display instead of the command output. This is needed for crc-org/tray-electron#114
@gbraad gbraad added kind/bug Something isn't working status/need triage labels Jan 11, 2022
@gbraad gbraad added kind/spike Investigation to provide direction and workable tasks priority/major and removed kind/bug Something isn't working status/need triage labels Jan 11, 2022
@gbraad
Copy link
Contributor Author

gbraad commented Jan 18, 2022

Moved to next sprint.

@gbraad gbraad changed the title Spike streaming JSON Spike streaming JSON for crc setup. Jan 26, 2022
This was referenced Feb 3, 2022
Closed
Closed
@gbraad gbraad linked a pull request Feb 16, 2022 that will close this issue
[WIP] Print JSON status of preflight checks #2984
Closed
@gbraad gbraad mentioned this issue Feb 16, 2022
Closed
4 tasks
@gbraad
Copy link
Contributor Author

gbraad commented Feb 16, 2022

Ideally this needs the step streamed BEFORE the result is known, and followed by the actual state is finished (passed/failed)

@cfergeau
Copy link
Contributor

Maybe the progress can only be shown for very long operations (download and uncompress), and all other operations don't need a progress bar because they are very fast?

@praveenkumar praveenkumar mentioned this issue Apr 8, 2022
Open
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Apr 17, 2022
@stale stale bot closed this as completed May 1, 2022
@anjannath anjannath reopened this May 2, 2022
@stale stale bot removed the status/stale Issue went stale; did not receive attention or no reply from the OP label May 2, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Jul 10, 2022
@stale stale bot closed this as completed Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anjannath anjannath

Labels
kind/spike Investigation to provide direction and workable tasks priority/major status/stale Issue went stale; did not receive attention or no reply from the OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Print JSON status of preflight checks anjannath/crc
3 participants
@gbraad @cfergeau @anjannath