Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Remove the use of the pull-secret file? #120

Open
gbraad opened this issue Jul 21, 2021 · 1 comment
Open

Remove the use of the pull-secret file? #120

gbraad opened this issue Jul 21, 2021 · 1 comment

Comments

@gbraad
Copy link

gbraad commented Jul 21, 2021

It seems the macOS app has a mixed usecase for an entered pull-secret on start and a pull-secret file from the settings? This might lead to confusion around the precedence and actual need. See:

https://github.com/code-ready/tray-macos/blob/007e3c872462cc5dded60b638d2bef7a84b6704d/CodeReady%20Containers/config/ConfigViewController.swift#L135-L138

It might be better to read the contents and then overwrite what is stored in secure storage. See related discussion here: crc-org/crc#2571 about the mixed use of the pull secret in store and the file path.

Note: for Windows I have proposed to remove the file option: crc-org/tray-windows#102

@gbraad
Copy link
Author

gbraad commented Jul 26, 2021

Note; the Windows solution got merged and no file option is offered

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant