This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Use a typed JSON result for the `/api/pull-secret` API endpoints #127

Open

gbraad opened this issue Aug 16, 2021 · 0 comments

Contributor

gbraad commented Aug 16, 2021

Instead of an empty or bare message, we should return a JSON message from the API: crc-org/crc#2648

For this to happen we need to change the following code:

https://github.com/code-ready/tray-windows/blob/482f4dafec482add25cbdbd92567521426807745/Communication/DaemonCommander.cs#L90

... which can be simplified to a basic response without the specific exception handling.

gbraad changed the title ~~Use a typed JSON result~~ Use a typed JSON result for the /api/pull-secret API endpoints

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.