Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS version checks to client API #132

Open
cfergeau opened this issue Apr 26, 2024 · 0 comments
Open

Add macOS version checks to client API #132

cfergeau opened this issue Apr 26, 2024 · 0 comments

Comments

@cfergeau
Copy link
Collaborator

cfergeau commented Apr 26, 2024

crc has code to check the macOS version which is mainly used to check for supported vfkit features https://github.com/crc-org/crc/blob/ec6cbfb3d35f433a6285bda4b12badb45e97f915/pkg/os/darwin/release_info.go#L22-L44
podman has similar requirements since it requires uefi support which was introduced in macos 13

It would be useful to have some version check code in the client code which could be shared between the various vfkit users.
Ideally this would also go with feature based checks, such as VFKIT_UEFI_MIN_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant