Thin jar: publish assembly jar (fat-jar) with classifier 'assembly' #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like that the main artifact is a thin-jar, usable as maven library dependency, having it's dependencies described in the maven pom.
…e test. Remove slf4j dependency as it is not used.
zzeekk
changed the title
|
Hi @nightscape, it would be nice if you could change to publish the default artifact as thin jar with an additional fat-jar artifact with classifier "assembly". WDYT? |
|
@zzeekk it would be great if you could rebase the PR and update the documentation. Please also try if the new instructions work, both in the command-line via spark-shell, as well as in a SBT/Mill/Gradle build (one should suffice). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #696, #697