Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol Update v5 #7

Open
chakrit opened this issue Aug 14, 2013 · 8 comments
Open

Protocol Update v5 #7

chakrit opened this issue Aug 14, 2013 · 8 comments

Comments

@chakrit
Copy link
Contributor

chakrit commented Aug 14, 2013

Have you seen: https://gist.github.com/frsyuki/5432559

TL;DR: There has been discussion over the problem with correctly differentiating string and binary in msgpack and so the owner has proposed a new spec with included built-in string support.

So wanna know your thoughts on this. Wether you will consider supporting it?


Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@chakrit
Copy link
Contributor Author

chakrit commented Aug 20, 2013

@creationix
Copy link
Owner

Is this official and all msgpack implementations need to migrate to it? Or is it an official proposal to create a new incompatible format? It looks like it breaks some backwards compat, but I'm not entirely sure.

@chakrit
Copy link
Contributor Author

chakrit commented Aug 20, 2013

@creationix yes tim, it's meant to be incompatible in order to fix the string vs binary issue and yeah i think it's official now that the spec file in msgpack/msgpack itself is updated (i.e. not a proposal anymore, real specs now)

@creationix
Copy link
Owner

My modifications fixed the string vs binary issue without breaking any backwards compatibility. Oh well.

But even if this new format is official, I imagine it will take a while for existing systems to upgrade to the new format since it's a breaking change. There will be a need for this implementation for a while longer I think.

@chakrit
Copy link
Contributor Author

chakrit commented Aug 20, 2013

Should I just fork and publish a new npm module instead? Or maybe stuck this in a branch somewhere besides master.

@creationix
Copy link
Owner

I guess publish your own. Both versions need to coexist.

I'm afraid this new version of the spec won't take off since it's incompatible. Remember what happened with python 3? And this case is worse because it's a network protocol and data format requiring interoperability between systems. Is there an official upgrade plan?

@chakrit
Copy link
Contributor Author

chakrit commented Aug 21, 2013

I think this is in a better position than Python 3 tho, since it doesn't require code changes to existing application. They just need to upgrade all the msgpack modules they use that are talking to each other. And I think people just use it mostly for internal communication between their app components? For talking to 3rd party I think most just sticks to JSON anyway.

And there's the string vs binary problem. So i think new implementers will definitely pick this new version over the old one.

@chakrit
Copy link
Contributor Author

chakrit commented Aug 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants