Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hover Effect to Navigation Bar Links #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Hover Effect to Navigation Bar Links #155

wants to merge 1 commit into from

Conversation

Njeringungu
Copy link

Fixes

Description

  • Added a hover effect with a text decoration of underline, using the --vocabulary-brand-color-turquoise color.

  • The addition helps make it clear the elements are clickable, improving user interaction and accessibility.

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Njeringungu Njeringungu requested review from a team as code owners October 8, 2024 23:05
@Njeringungu Njeringungu requested review from TimidRobot, possumbilities, MuluhGodson and zackkrida and removed request for a team October 8, 2024 23:05
@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 3bf8e7c
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6705babd1fe3bb0008e98bb2
😎 Deploy Preview https://deploy-preview-155--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egbadon-victor
Copy link
Contributor

Hi @Njeringungu

This is an awesome solution you have here. Based on the contibution guides, you are only supposed to submit a pull request for an issue that has a tag with status:ready for work. The issue that this PR is addressing is marked status : awaiting triage. I noticed you were the one that raised the issue. Notwithstanding you would still need to wait until it has been marked with the appropriate tags before making a PR.

Here is a link to the Contribution Guidelines for more context.

@Njeringungu
Copy link
Author

@egbadon-victor Noted,
Thank you for highlighting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot Awaiting requested review from TimidRobot TimidRobot is a code owner automatically assigned from creativecommons/technology

@possumbilities possumbilities Awaiting requested review from possumbilities possumbilities is a code owner automatically assigned from creativecommons/technology

@MuluhGodson MuluhGodson Awaiting requested review from MuluhGodson MuluhGodson is a code owner automatically assigned from creativecommons/ct-vocabulary-core-committers

@zackkrida zackkrida Awaiting requested review from zackkrida zackkrida is a code owner automatically assigned from creativecommons/ct-vocabulary-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
WebDev
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Enhancement: Add Hover Effect to Navigation Bar Links for Better User Experience
2 participants
@Njeringungu @egbadon-victor