Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functionality] Research, design, and scope an implementation of Accordions for use within the Vocabulary design system #200

Open
1 task done
possumbilities opened this issue Oct 14, 2024 · 1 comment
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Oct 14, 2024

Description

The need for such a feature is outlined in:

However, there are myriad of approaches worth considering and there needs to be more focused work before fully implementing such a feature.

This Issue would need to house the findings and direction for such a feature more specifically.

Implementation

  • I would be interested in implementing this feature.
@possumbilities possumbilities added 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to CC staff members labels Oct 14, 2024
@possumbilities possumbilities self-assigned this Oct 14, 2024
@OmarAmeen01
Copy link
Contributor

@possumbilities

here is my opinion I am open for changes and adjustments required
this component needs to be as general as possible with minimum adjustments needed and that even should be achieved with out introducing more complexity to the codebase for that what I'm suggesting is

make a component containing the structure of the accordion like this

   <article>
    <h1 >Frequently asked Questions</h1>
       <button aria-expanded="false"  class="accordion-header" aria-controls="answer1">Question you might have?
           <img src="chevron.svg" alt="" class="accordion-chevron">
       </button>
   <p id="answer1" class="hidden" role="region" aria-labelledby="question1">Answer to the question</p>

we will provide this component in the documentation from where user can copy it and paste it in thier code
then we will write the css and js logic for the accordion in src folder of vocabulary and also provide svg for the chevron of accordion so when user inserts the element into his code using vocabulary he wont have to worry about the css and js just pasting the component as its will do the magic and user can change the inner html of the element according to his choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

2 participants