Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Lot of encoding errors on docs/index.html #283

Open
1 task done
OmarAmeen01 opened this issue Oct 23, 2024 · 4 comments
Open
1 task done

[Bug] Lot of encoding errors on docs/index.html #283

OmarAmeen01 opened this issue Oct 23, 2024 · 4 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@OmarAmeen01
Copy link
Contributor

OmarAmeen01 commented Oct 23, 2024

Description

There are lot of encoding errors on docs/index.html eg

  1. Raw ">" must be encoded as >
  2. Expected omitted end tag <img> instead of self-closing element <img/>
  3. <img> is missing required"alt"attribute
  4. trailing whitespace
  5. Expected omitted end tag <link> instead of self-closing element <link/>
  6. Landmarks must have a non-empty and unique accessible name (aria-label or aria-labelledby)
    There are also other errors like
    <article>, <aside>, <nav>, <header> element can not be permited as content under <code> tag but these can be ignored as this is intended

Reproduction

1.install html-validate as global dependency
3. run html-validate on docs/html
2. Observer the error in the terminal for the file

Expectation

Fixing all these error at once per file

Environment

  • Device: (_ iPhone Xs; laptop)
  • OS: (_ iOS 13.5; Fedora 32)
  • Browser: (_Safari; Firefox)

Resolution

  • I would be interested in resolving this bug.
@OmarAmeen01 OmarAmeen01 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 23, 2024
@egbadon-victor
Copy link
Contributor

Hey @OmarAmeen01

Awesome observations! I think it will be helpful to split these issues into smaller ones that can be handled in a single PR. Each bullet point can be raised as an issue of it's own

@possumbilities
Copy link
Contributor

I would second @egbadon-victor's observations. This needs to be split (also verify none of these are duplicates of any existing Issues).

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 23, 2024
@OmarAmeen01
Copy link
Contributor Author

ok @possumbilities should I close these two issues and raise separate issue for each error that occurs across various contexts

@rahulptl165
Copy link
Contributor

hi @TimidRobot i have created pull request for this issue(#283). please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants