-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak wording of provider.name
entry
#162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scouten-adobe
commented
Aug 5, 2024
docs/modules/ROOT/pages/index.adoc
Outdated
@@ -972,7 +972,7 @@ The `verifiedIdentities[?].provider.id` MUST be present and MUST be a valid URI | |||
|
|||
[#vc-credentialsubject-verifiedidentity-provider-name] | |||
Identity provider name::: | |||
The `verifiedIdentities[?].provider.name` MUST be present and MUST NOT be empty. The `verifiedIdentities[?].provider.name` property is the name of the _<<_identity_provider,identity provider>>._ | |||
The `verifiedIdentities[?].provider.name` MUST be present and MUST be a non-empty string. The `verifiedIdentities[?].provider.name` property is the user-visible name of the _<<_identity_provider,identity provider>>._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per 05 Aug 2024 CAWG meeting, if this is a user-visible string, then we should consider how a browser or other UX implementation would localize it.
See https://www.w3.org/TR/vc-data-model-2.0/#language-and-base-direction for advice on multi-language scenarios. |
…bout "user-visible string" This borrows from W3C VC 2.0's approach to localizable text contained within credentials.
# Conflicts: # docs/modules/ROOT/pages/index.adoc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.