Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly state what is being signed in an identity assertion #62

Closed
1 task done
paulengland opened this issue Mar 4, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
MAJOR Especially difficult issue pending-pr-review Resolved, pending PR review
Milestone

Comments

@paulengland
Copy link

paulengland commented Mar 4, 2024


Presumably something like "The signature is formed over the canonical CBOR serialization of the referenced_assertions field"

Also: Should we call the envelope "identity-map" for uniformity?

@paulengland
Copy link
Author

A more future-proof method might be to define an identity-assertions-tbs (to be signed) map that contains referenced_assertions so that it's less disruptive if we ever want to add new data to the stuff signed by an identity signer. See, for example, #65

@scouten-adobe scouten-adobe added this to the 1.0 milestone Mar 8, 2024
@scouten-adobe scouten-adobe added the MAJOR Especially difficult issue label Mar 8, 2024
@scouten-adobe scouten-adobe self-assigned this Mar 12, 2024
@scouten-adobe scouten-adobe added the pr-needed Action item to create a PR label Mar 12, 2024
@scouten-adobe
Copy link
Contributor

Related to #68

@scouten-adobe
Copy link
Contributor

I believe this was addressed by #75. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAJOR Especially difficult issue pending-pr-review Resolved, pending PR review
Projects
None yet
Development

No branches or pull requests

2 participants