Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Test: optionally, don't fail on additional records. #236

Open
Tracked by #290
big-andy-coates opened this issue Feb 14, 2023 · 2 comments
Open
Tracked by #290

System Test: optionally, don't fail on additional records. #236

big-andy-coates opened this issue Feb 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@big-andy-coates
Copy link
Member

big-andy-coates commented Feb 14, 2023

topic expectations should be able to define if they are an exact list of records to expect, or a subset of records that must be produced, i.e. should a test fail on additional records?

This is potentially most usefully declared at the TopicExpectation level. However, need to think about the implications of this...

What if two expectations files cover the same topic and one does and one does not "fail on additional". Maybe this is OK if we inverse it to "swallow additional" rather than "fail on additional". Then if one swallows... additional are swallowed.

What if an expectation file doesn't define a top level topic name, but instead contains expected records from multiple topics. I guess if the expectation is configured to "swallow" then we'd swallow all topics references.

More thought required, but may be a useful enhancement to the suite level "additional records handling" customisation task, worth breaking out into a secondary follow on task.

@big-andy-coates big-andy-coates added the enhancement New feature or request label Feb 14, 2023
@big-andy-coates big-andy-coates self-assigned this Feb 14, 2023
@big-andy-coates
Copy link
Member Author

Should the expectation ordering, currently define in the KafkaOptions class, also be defined at the TopicExpectation level instead?

@big-andy-coates
Copy link
Member Author

big-andy-coates commented Mar 10, 2023

The ks-connected-services-demo would benefit from updating to use this new option once its ready.

https://github.com/creek-service/ks-connected-services-demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant