Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom endpoints #411

Open
big-andy-coates opened this issue Nov 28, 2023 · 1 comment
Open

Custom endpoints #411

big-andy-coates opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@big-andy-coates
Copy link
Member

big-andy-coates commented Nov 28, 2023

Currently Kafka endpoints are read from environment variables and the JSON schema serde under development likewise reads the Schema Registry endpoint from environment variables.

Both of these should be customisable. Currently this is overridden via the context builder. This is wrong, as its incompatible with system tests, which require the endpoints to be read from environment properties.

We should:

  1. Provide a mechanism for injecting new (secure) endpoint providers for both Kafka and SR, e.g. an environment var that points to a custom implementation to use. (The system tests won't set this new env var, so services will default to loading end points from env vars, which is compatible with system tests).
  2. Remove the ability of customising this on the service context builder, as its misleading. This will still be needed internally, as we'll need in inject mocks for unit testing. (e.g. TestKafkaStreamsExtensionOptions). But it should be moved to an internal interface / type.
@big-andy-coates big-andy-coates added the enhancement New feature or request label Nov 28, 2023
@big-andy-coates big-andy-coates self-assigned this Nov 28, 2023
@big-andy-coates
Copy link
Member Author

Second part is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant