Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach: Select an ID from the list table has tons of whitespace #399

Closed
nromito opened this issue Jul 19, 2021 · 4 comments · Fixed by #460
Closed

Attach: Select an ID from the list table has tons of whitespace #399

nromito opened this issue Jul 19, 2021 · 4 comments · Fixed by #460
Assignees
@seanvaleo
Labels
cli
Milestone
0.7.2

Comments

@nromito
Copy link
Collaborator

nromito commented Jul 19, 2021

image
@pdugas pdugas added the cli label Jul 19, 2021
@pdugas
Copy link
Collaborator

pdugas commented Jul 19, 2021

Happens with scope ps and scope attach NAME and is due to the column-layout.

@ledbit ledbit added this to the 0.7.2 milestone Jul 19, 2021
@seanvaleo
Copy link
Collaborator

Seems to be an issue with the table rendering. After trying to use the options in the library to no avail, I have filed an issue : olekukonko/tablewriter#189

@seanvaleo
Copy link
Collaborator

@coccyx are you aware of any option we can set that will fix this?

@coccyx
Copy link
Collaborator

coccyx commented Jul 30, 2021

Not that I know of. We'll probably have to fix it in the library ourselves and send a PR (although it looks like a ton of PRs are piling up). We could also pretty easily replace the table library as well, and there are likely other options.

michalbiesek added a commit to michalbiesek/appscope that referenced this issue Aug 9, 2021
@michalbiesek
Replace tablewriter go deps
5575fd0 
Extend table configuration with SetTrimWhiteSpaceAtEOL, which
removes trailing whitespaces

Closes criblio#399
@michalbiesek michalbiesek mentioned this issue Aug 9, 2021
Merged
michalbiesek added a commit to michalbiesek/appscope that referenced this issue Aug 9, 2021
@michalbiesek
Replace tablewriter go deps
06988b7 
Extend table configuration with SetTrimWhiteSpaceAtEOL, which
removes trailing whitespaces, change order of fields so the
longest string will be the last one

Closes criblio#399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanvaleo seanvaleo

Labels
cli
Projects
None yet
Milestone
0.7.2
Development

Successfully merging a pull request may close this issue.

Replace tablewriter go deps michalbiesek/appscope
5 participants
@pdugas @coccyx @nromito @ledbit @seanvaleo