Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on s390x architecture #52

Open
Maytha8 opened this issue Dec 31, 2023 · 1 comment · May be fixed by #54
Open

Build fails on s390x architecture #52

Maytha8 opened this issue Dec 31, 2023 · 1 comment · May be fixed by #54

Comments

@Maytha8
Copy link

Maytha8 commented Dec 31, 2023

Hi,

When building saferith on s390x, it fails, as arith_s390x_test.go states package big rather than package saferith.

Specifically, this is failing on Debian Unstable s390x. You can see the full Debian CI log here. Relevant part from log:

found packages saferith (arith.go) and big (arith_s390x_test.go) in <BUILDPATH>/saferith

AFAIK the solution to change out package big for package saferith in arith_s390x_test.go

Thanks!
@JohnStrunk JohnStrunk mentioned this issue Mar 19, 2024
Open
@Maytha8
Copy link
Author

Maytha8 commented Jan 4, 2025

It looks like it also contains references to nonexistent functions, probably the ones defined in the Go codebase.

eclipseo added a commit to eclipseo/saferith that referenced this issue Jan 7, 2025
@eclipseo
Fix build for s390x architectures
362a27e 
 - Prefix addvectorfacility/subvectorfacility in arith_s390x.s to avoid
   conflict with math/big
 - Correct package name in architecture arith_s390x_test.go

F8x cronokirby#52
eclipseo added a commit to eclipseo/saferith that referenced this issue Jan 7, 2025
@eclipseo
Fix build for s390x architectures
44f5acf 
 - Prefix addvectorfacility/subvectorfacility in arith_s390x.s to avoid
   conflict with math/big
 - Correct package name in architecture arith_s390x_test.go

Fix cronokirby#52
@eclipseo eclipseo linked a pull request Jan 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build for s390x architectures eclipseo/saferith
1 participant
@Maytha8