Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support output overrides #48

Open
fernandezcuesta opened this issue Nov 4, 2024 · 1 comment · May be fixed by #49
Open

Support output overrides #48

fernandezcuesta opened this issue Nov 4, 2024 · 1 comment · May be fixed by #49
Labels
enhancement New feature or request

Comments

@fernandezcuesta
Copy link
Contributor

fernandezcuesta commented Nov 4, 2024

What problem are you facing?

Add the ability to override the merged context with fields coming from the XR.
For example this is useful in scenarios where we load fields from an EnvironmentConfig such as region and we want to transparently override this to all context users (subsequent pipeline steps) with a value from the XR (e.g. under spec.parameters.region).
Even though this could be done by adding an additional step to mutate the context, doing this from function-environment-config would be useful and saves an extra step in the pipeline.

How could this Function help solve your problem?

Implement a way to copy a value from an XR path to the resulting (merged) context.

@fernandezcuesta fernandezcuesta added the enhancement New feature or request label Nov 4, 2024
@phisco
Copy link
Collaborator

phisco commented Nov 5, 2024

Wouldn't this effectively be equivalent to supporting spec.environment.patches here too as we already do in function-patch-and-transform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants