Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(projects): add sourceNamespaces field to ProjectParameters #199

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat(projects): add sourceNamespaces field to ProjectParameters #199

merged 1 commit into from
Sep 23, 2024

Conversation

smileisak
Copy link
Contributor

Description of your changes

Adds sourceNamespaces field to the MR so the project can be used in the Application in any Namespace context.

Fixes #198

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

kubectl apply -f examples/projects/project-with-source-namespaces.yaml

janwillies
janwillies approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@janwillies janwillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @smileisak!

@janwillies janwillies merged commit 1568f5c into crossplane-contrib:main Sep 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janwillies janwillies janwillies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SourceNamespaces field to Project MR to be able to use Application in any namespace feature of argocd
2 participants
@smileisak @janwillies