Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add desired state changed event filter to all controllers #498

Open
turkenh opened this issue Mar 21, 2023 · 2 comments · May be fixed by #505
Open

Add desired state changed event filter to all controllers #498

turkenh opened this issue Mar 21, 2023 · 2 comments · May be fixed by #505
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@turkenh
Copy link
Contributor

turkenh commented Mar 21, 2023

What problem are you facing?

With crossplane/crossplane-runtime#372, we have introduced a DesiredStateChanged to the xp runtime, which would filter out status update events.

We need to add this as an event filter to all controllers. Similar to crossplane-contrib/provider-aws#1705

How could Crossplane help solve your problem?

Add desired state changed event filter to all controllers.
@turkenh turkenh added enhancement New feature or request good first issue Good for newcomers labels Mar 21, 2023
@turkenh turkenh mentioned this issue Mar 21, 2023
Open
@anurag-rajawat
Copy link

@turkenh may I work on this one?

@turkenh
Copy link
Contributor Author

turkenh commented Apr 24, 2023

@turkenh may I work on this one?

Sure, that would be great 👍

anurag-rajawat added a commit to anurag-rajawat/provider-gcp that referenced this issue Apr 24, 2023
@anurag-rajawat
Add desired state changed event filter to all controllers (crossplane…
57f50fb 
…-contrib#498)

Signed-off-by: Anurag Rajawat <[email protected]>
@anurag-rajawat anurag-rajawat linked a pull request Apr 24, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add desired state changed event filter to all controllers (#498) anurag-rajawat/provider-gcp
2 participants
@turkenh @anurag-rajawat