Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip set if valueFrom source ref is optional and missing #265

Open
simonklb opened this issue Jan 9, 2025 · 0 comments
Open

Skip set if valueFrom source ref is optional and missing #265

simonklb opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@simonklb
Copy link

simonklb commented Jan 9, 2025

What problem are you facing?

With a release spec like this:

forProvider:
  set:
    - name: foo
      valueFrom:
        secretKeyRef:
          name: bar
          namespace: baz
          key: optionalKey
          optional: true

The release installation fails with missing value for --set if the secret is missing.

How could Crossplane help solve your problem?

To make optional source refs useful in the context of set would it not make sense to also skip the set if the value is missing? Two possible solutions I see would be to either check if the value source is optional and skip it or introduce a way of marking a set optional as well.

@simonklb simonklb added the enhancement New feature or request label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant