Expose an option to reject unknown JSON members #123
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Closes #121
@phisco This is how I would wrap JSON options in our own, to avoid coupling ourselves to the upstream (and not yet stable) json-experiment implementation too strongly.
I'm opening as a draft though because after writing this it occurred to me that I'd prefer to make
RejectUnknownMembers
the default behavior forAsObject
. My rationale:protojson.Marshal
(i.e.AsStruct
).I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested