Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] build failed on the crossplane-runtime v1.16 #137

Closed
Peefy opened this issue May 17, 2024 · 1 comment · Fixed by #138
Closed

[email protected] build failed on the crossplane-runtime v1.16 #137

Peefy opened this issue May 17, 2024 · 1 comment · Fixed by #138
Labels
bug Something isn't working

Comments

@Peefy
Copy link

Peefy commented May 17, 2024

What happened?

I've updated the crossplane-runtime v1.16 deps for the function-kcl, but it builds failed in CI. See the PR crossplane-contrib/function-kcl#105 and the CI pipeline https://github.com/crossplane-contrib/function-kcl/actions/runs/9106600367/job/25034062200?pr=105

How can we reproduce it?

In the function-kcl repo https://github.com/crossplane-contrib/function-kcl and bump the crossplane-runtime to v1.16, then build the code.

What environment did it happen in?

Crossplane version: v1.16
CI environment: https://github.com/crossplane-contrib/function-kcl/blob/main/.github/workflows/ci.yaml

@Peefy Peefy added the bug Something isn't working label May 17, 2024
@wayfrro
Copy link

wayfrro commented May 20, 2024

Same problem here:

# github.com/crossplane/function-sdk-go/resource/composed
/home/poe/go/pkg/mod/github.com/crossplane/[email protected]/resource/composed/composed.go:125:27: cannot use &Unstructured{} (value of type *Unstructured) as "github.com/crossplane/crossplane-runtime/pkg/resource".Composed value in variable declaration: *Unstructured does not implement "github.com/crossplane/crossplane-runtime/pkg/resource".Composed (missing method GetObservedGeneration)
# github.com/crossplane/function-sdk-go/resource/composite
/home/poe/go/pkg/mod/github.com/crossplane/[email protected]/resource/composite/composite.go:49:28: cannot use &Unstructured{} (value of type *Unstructured) as "github.com/crossplane/crossplane-runtime/pkg/resource".Composite value in variable declaration: *Unstructured does not implement "github.com/crossplane/crossplane-runtime/pkg/resource".Composite (missing method GetObservedGeneration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants