Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add Quote Effect: Return Quote ID in effectOutput #2822

Open
dennisrijsdijk opened this issue Sep 19, 2024 · 0 comments
Open

[Feature Request] Add Quote Effect: Return Quote ID in effectOutput #2822

dennisrijsdijk opened this issue Sep 19, 2024 · 0 comments
Labels
Dev Complete Enhancement A feature request or improvement Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@dennisrijsdijk
Copy link
Collaborator

Describe the solution you'd like
Return the quote ID for the created quote as an effect output

Additional context
This would allow custom quote commands to return the proper quote ID
@dennisrijsdijk dennisrijsdijk added the Enhancement A feature request or improvement label Sep 19, 2024
dennisrijsdijk added a commit to dennisrijsdijk/Firebot that referenced this issue Sep 19, 2024
@dennisrijsdijk
feat: quote id effect output (crowbartools#2822)
453a90d
@dennisrijsdijk dennisrijsdijk mentioned this issue Sep 19, 2024
Merged
@dennisrijsdijk dennisrijsdijk added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 19, 2024
CaveMobster pushed a commit that referenced this issue Sep 24, 2024
@dennisrijsdijk
feat: quote id effect output (#2822) (#2823)
954a9e3 
* feat: quote id effect output (#2822)

* chore: rename to model
@CaveMobster CaveMobster added Release Pending Issue has been resolved and is waiting to be packaged as part of a release and removed Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dev Complete Enhancement A feature request or improvement Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Firebot
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dennisrijsdijk @CaveMobster