-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translators to Co-Authored-By #35
Comments
Totally agree. Weblate already has the feature: firewalld/firewalld#697, Radarr/Radarr@aafd82b. Translators from the community are entitled to be properly recognized and attributed. Without such a feature, a human would be needed to lookup, review and compile a list of contributors, which is time-consuming and slows the translation acceptance process. |
The problem here is that we need to know the translators' emails that they've added to their GitHub accounts. These can be different from the emails known to Crowdin. Also, this is a kind of personal info disclosure, so we'll need to ask for permission to put their name & email in the commit message and then store it somewhere in Crowdin. Anyway, I'll be happy to see this feature at least in the Crowdin API and CLI. |
Not a problem, just use the one they use for Crowdin. It's about attribution, not GitHub itself.
I mean, a generic "Allow the project manager to attribute my name and email on external services" setting on Crowdin would be good. I'm sure most project managers want to attribute translators anyway? |
agree |
Having this feature would significantly enhance user interaction 🚀. When receiving translations, I ask the translators to provide their GitHub usernames in the chat. However, we could streamline this process by implementing an opt-in system where users link their GitHub accounts. If a GitHub account is connected, it could automatically include their account as a co-author. It's worth noting that I haven't explored whether their GitHub email addresses are accessible to third-party services in this manner. Typically, I retrieve this information by adding the |
I think it's better to use |
Is your feature request related to a problem? Please describe.
When a translation PR comes through, it's attributed to just Crowdin Bot, which is a tad unfair on the actual translators.
Describe the solution you'd like
Use
Co-Authored-By
to attribute the actual people who worked on the translations.Describe alternatives you've considered
Using the Last-Translator flag on the file, but that only attributes the latest author
Additional context
Translators are just as important to a project as a Developer is, by making use of the Co-Authored-By feature in git, we can give them some credit for their work.
The text was updated successfully, but these errors were encountered: