Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lint configuration; require go 1.22 #375

Merged
merged 1 commit into from
Jul 18, 2024
Merged

update lint configuration; require go 1.22 #375

merged 1 commit into from
Jul 18, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 17, 2024

No description provided.

@mmetc mmetc added this to the 0.0.29 milestone Jul 17, 2024
@mmetc mmetc requested a review from sabban July 17, 2024 14:05
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 04a2f64 into main Jul 18, 2024
5 checks passed
@mmetc mmetc deleted the lint-config branch July 18, 2024 14:41
@ne20002
Copy link

ne20002 commented Jul 18, 2024

Hi @mmetc , @sabban
I just saw that the required go version has been updated to 1.22. This prevents the update of the bouncer for OpenWrt 23.05 (the current stable release). OpenWrt 23.05 has go 1.21.12 and will most likely not upgrade to 1.22.
Is there a chance to revert this version upgrade or is go 1.22 required?
It would be a bit disapointing for a few users if the OpenWrt Crowdsec bouncer can't be upgraded to 0.0.29 only because of the golang version.

The Go version already prevented to update the Crowdsec package for OpenWrt 23.05. Not a big issue as not very much users use it but for the bouncer there is a reasonable number of user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants