Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for data entity existence in the RO-Crate payload #60

Open
simleo opened this issue Jan 15, 2025 · 0 comments
Open

Check for data entity existence in the RO-Crate payload #60

simleo opened this issue Jan 15, 2025 · 0 comments

Comments

@simleo
Copy link
Member

simleo commented Jan 15, 2025

As pointed out by @elichad in ResearchObject/ro-crate#390 (comment), the RO-Crate Structure section of the spec states that:

Data Entities in the RO-Crate MUST either be payload files/directories present within the RO-Crate root directory or its subdirectories, or be Web-based Data Entities.

We are currently not checking that the RO-Crate payload (i.e. the contents of the crate's directory tree) actually contains files and directories listed in the metadata. We need to add this check, but we should consider having an option to disable it in order to support use cases where one just wants to check the metadata, e.g. for performance reasons. In particular, it should be noted that many of our tests do not include payload files, taking advantage of the current situation to avoid adding a large number of files overall.

important: the check needs to take into account the escaping of special characters in data entity @ids, see Describing entities in JSON-LD where it says that:

Care must be taken to express any relative paths using / separator and escape special characters like space (%20).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant