Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Display Cryostat Agent Topology nodes with Cryostat icon #1114

Closed
andrewazores opened this issue Sep 20, 2023 · 0 comments · Fixed by #1115
Closed

[Request] Display Cryostat Agent Topology nodes with Cryostat icon #1114

andrewazores opened this issue Sep 20, 2023 · 0 comments · Fixed by #1115
Assignees
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

Describe the feature

Currently, all JVM targets on the Topology view are rendered with the OpenJDK Duke icon to represent them.

image

https://github.com/cryostatio/cryostat-web/blob/main/src/app/assets/openjdk.svg

It would be nice to differentiate JMX targets from Cryostat Agent targets at a quick glance, especially after cryostatio/cryostat-agent#203 .

This could be done quite easily and IMO effectively by using Duke to represent JMX targets, and the Cryostat icon for Agent targets. The Cryostat icon has two variants for light vs dark backgrounds so this should also be accounted for when the icon is rendered - this is already done in ex. the navigation masthead, so that may be a useful reference for how to do the same thing in the Topology view.

https://github.com/cryostatio/cryostat-web/blob/main/src/app/assets/cryostat_icon_rgb_default.svg
https://github.com/cryostatio/cryostat-web/blob/main/src/app/assets/cryostat_icon_rgb_reverse.svg

Anything other information?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant