[Bug] Topology "copy to clipboard" action fails

[andrewazores]

Current Behavior

Clicking the "copy to clipboard" icon on the Topology > Create Custom Target view fails. An error appears in the console and the text is not copied into the system clipboard.

Expected Behavior

There should be no error in the console and the text should be copied into the clipboard.

Steps To Reproduce

1. Run Cryostat 2.5.0-snapshot
2. Go to Topology > Create Custom Target
3. Click the clipboard icon to copy the example JMX URL

Environment

Cryostat 2.5.0

In Cryostat 2.4.0(-pre) this works as expected.

Anything else?

[tthvo]

Sorry, I have been checking this out and seems to be working: directly with cryostat server and via yarn start:dev.

[tthvo]

Maybe, it is some browser restrictions that prevents clipboard from being available?

[andrewazores]

Hmm. Okay, I'll check again with another browser or with extensions disabled or something. Could just be on my end. Maybe I tested on version in a regular browser window and the other in private/incognito with no extensions and that's where the difference came in.

[andrewazores]

Hmm, I can't reproduce this anymore either. It probably was just something with my browser setup at the time.

[andrewazores]

Hang on, actually, I can reproduce it by building and smoketesting cryostat3. That's using what should be the same cryostat-web version as 2.5.0-snapshot however, so I'm not sure where the difference lies. I wonder if the 3.0 build is doing something wrong with the dependency lockfile.

[tthvo]

Ahh right I saw the same thing. I suppose this is the issue: https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

This requires a secure origin — either HTTPS or localhost (or disabled by running Chrome with a flag). Just like for ServiceWorker, this state is indicated by the presence or absence of the property on the navigator object.

https://developers.google.com/web/updates/2018/03/clipboardapi

This is noted in the spec with [SecureContext] on the interface: https://w3c.github.io/clipboard-apis/#dom-navigator-clipboard

You can check the state of window.isSecureContext to learn if that's the reason a feature is unavailable. Secure contexts | MDN

When I tried with http://localhost:8181, it worked fine. However, http://cryostat3:8181 failed as in the issue.

[tthvo]

For cryostat3 hostname over HTTP:

For localhost hostname over HTTP:

[andrewazores]

Ahh, nice find, thanks!