-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(recordings): render labels in 'key=value' form #1313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
label-rendering
branch
3 times, most recently
from
July 30, 2024 19:03
736af79
to
ede7c14
Compare
andrewazores
force-pushed
the
label-rendering
branch
from
July 30, 2024 19:11
ede7c14
to
908a69a
Compare
This PR/issue depends on:
|
andrewazores
changed the title
fix(topology): render labels/annotations in 'key: value' form
fix(recordings): render labels in 'key=value' form
Jul 30, 2024
Looks like test snapshots need updating? |
Needs a little more cleanup work, there was some internal logic that handled KeyValues by encoding them as |
tthvo
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
See #1311
Based on #1312
Description of the change:
This change adds allows a match expression example to be copied to the clipboard...
Motivation for the change:
This change is helpful because users may want to copy the example for easier use...
How to manually test: