Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): update web-client to use v4 API endpoint #1331

Merged
merged 27 commits into from
Oct 1, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Aug 20, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Part of: 550
depends on: 584

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309 aali309 self-assigned this Aug 20, 2024
@aali309 aali309 added the feat New feature or request label Aug 20, 2024
@mergify mergify bot added the safe-to-test label Aug 20, 2024
@andrewazores andrewazores mentioned this pull request Sep 4, 2024
7 tasks
@andrewazores andrewazores marked this pull request as ready for review September 5, 2024 15:16
@Josh-Matsuoka
Copy link
Contributor

Saw a test failure on first run, building again it passed, is this one known to be flaky?

[test] Summary of all failing tests
[test]  FAIL  src/test/Rules/CreateRule.test.tsx (16.171 s)
  ● <CreateRule /> › should submit form when form input is valid and create button is clicked
[test] 
    thrown: "Exceeded timeout of 5000 ms for a test.
    Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

      209 |   });
[test]       210 |
    > 211 |   it('should submit form when form input is valid and create button is clicked', async () => {
          |   ^
      212 |     const { user } = render({
      213 |       routerConfigs: {
      214 |         routes: [

      at src/test/Rules/CreateRule.test.tsx:211:3
      at Object.<anonymous> (src/test/Rules/CreateRule.test.tsx:82:1)

@andrewazores
Copy link
Member

There are a few tests that seem to be occasionally flaky. I can't recall if I have seen that particular one before, but it looks vaguely familiar. I don't know if somehow it has to do with test run ordering, or if maybe because the tests run against a headless browser if there is some delay on the browser DOM rendering side, or else what the root cause could be.

Josh-Matsuoka
Josh-Matsuoka previously approved these changes Oct 1, 2024
Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.95.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.94.0...v5.95.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…statio#1428)

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.36.1 to 7.37.0.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.36.1...v7.37.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andrewazores andrewazores merged commit 2336e55 into cryostatio:main Oct 1, 2024
13 checks passed
@aali309 aali309 deleted the updateWebClientToUseV4 branch October 29, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants