-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pf5): fix broken tests after PF5 upgrades #1347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
changed the title
test(pf5): fix broken unit tests after PF5 upgrades
test(pf5): fix broken tests after PF5 upgrades
Sep 9, 2024
tthvo
force-pushed
the
pf5-rec-tests
branch
from
September 10, 2024 00:46
7317d47
to
a2f5db6
Compare
7 tasks
Pheww! I think the tests are all updated to accommodate the PF5 upgrades now :D Not satisfied with it though, as many test logics are not yet standardized (i.e. repeated or done differently). I hope there will be some time to get to #848 to clean things up :D And many thanks again to @maxcao13 for helping out with this work!!! |
I'll start reviewing this now, but it might take a bit of time :-) |
andrewazores
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Description of the change:
Unit/Integration tests
Fixed broken tests after upgrading to Patternfly 5. This PR involves the following changes to the tests:
ref
(See below notes).act
where applicable, for example, actions that opens modal.I also added some tips/notes (i.e.
TESTING.md
) that I figured out when fixing the tests.Other bug fixes
Thanks to the unit tests, the following bugs are fixed:
SearchInput
for agent template search bar (i.e. has Search icon for consistency).Notes
There are some odd instances where snapshot test environment messes up DOM testing with
react-testing-library
. For example,createNodeMock
(only for snapshot rendering) is leaked into other DOM tests.Reordering the snapshot tests to last solved the problem. We might need some restructuring in #661 to split the 2 types of unit tests.