Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Local storage keys should have cryostat prefix #1451

Open
tthvo opened this issue Oct 17, 2024 · 0 comments
Open

[Task] Local storage keys should have cryostat prefix #1451

tthvo opened this issue Oct 17, 2024 · 0 comments
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere chore Refactor, rename, cleanup, etc. good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented Oct 17, 2024

Descriptions

I think some prefixes (e.g. cryostat.) should be added to local storage keys in order to distinguish them from others, which might be used third-party packages. Furthermore, since Cryostat and Grafana are now being served at the same origin, they do share the same local storage.

I guess it would avoid any potential collision that could result in the console crashing.

References

export enum LocalStorageKey {
ASSET_VERSION,
FEATURE_LEVEL,
DASHBOARD_CFG,
AUTOMATED_ANALYSIS_FILTERS,
TARGET_RECORDING_FILTERS,
CREDENTIAL_LOCATION,
TARGET,
TARGET_FAVORITES,
TOPOLOGY_GRAPH_POSITONS,
TOPOLOGY_NODE_POSITIONS,
TOPOLOGY_CONFIG,
TOPOLOGY_FILTERS,
AUTO_REFRESH_ENABLED,
AUTO_REFRESH_PERIOD,
AUTO_REFRESH_UNITS,
AUTOMATED_ANALYSIS_RECORDING_CONFIG,
CHART_CONTROLLER_CONFIG,
DELETION_DIALOGS_ENABLED,
VISIBLE_NOTIFICATIONS_COUNT,
NOTIFICATIONS_ENABLED,
WEBSOCKET_DEBOUNCE_MS,
DATETIME_FORMAT,
MATCH_EXPRES_VIS_GRAPH_POSITIONS,
MATCH_EXPRES_VIS_NODE_POSITIONS,
THEME,
}

@tthvo tthvo added good first issue Good for newcomers chore Refactor, rename, cleanup, etc. labels Oct 17, 2024
@andrewazores andrewazores added the breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere label Oct 17, 2024
@andrewazores andrewazores moved this to Backlog in 4.0.0 release Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere chore Refactor, rename, cleanup, etc. good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants