Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Implement finer-grained recording duration filter #512

Closed
andrewazores opened this issue Sep 19, 2022 · 2 comments
Closed

[Task] Implement finer-grained recording duration filter #512

andrewazores opened this issue Sep 19, 2022 · 2 comments
Labels
feat New feature or request good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

Speaking of toolbars, I just noticed something about the Duration filter in the toolbar.

The two "started before/after" filters have a magnifying glass search button to perform the filter after selecting the date/time parameters. The other filters have a dropdown menu (Select) and selecting an item immediately starts the filtering with that item. All good so far.

For the Duration filter, clicking the Continuous checkbox starts filtering for recordings with a continuous duration. Unchecking the box removes the filter. There doesn't seem to be a way to filter for recordings that are not continuous, other than by using the numeric duration filter.

The numeric duration filter only allows for matching exact recording durations, not greater-than or less-than, which I think is okay (for now), but to actually add this filter the user has to click the numeric input field and then press Enter.

Here's my idea for how to make this filter control a little more intuitive, at least to me:

  1. Add a magnifying glass button like the "started before/after" filter which actually adds a filter based on the selected criteria
  2. Remove the static "Continuous" checkbox
  3. Add a Select with values Continuous, Greater Than, Less Than
  4. Add a secondary control that varies according to the value selected above:
    4a. If Continuous, dynamically display a "Continuous" checkbox. The state of this checkbox becomes a "continuous == state" filter when the magnifying glass is clicked. This way the user can filter by only continuous recordings, or only fixed durations
    4b. If Greater Than or Less Than, dynamically display a duration picker. I think this should match the duration field on the recording creation form, with a number input and a separate units input. When the magnifying glass is clicked then apply a filter that looks for recordings fitting the specific criteria, ex. "recordings with fixed duration less than 5 minutes".

This is best suited for a separate PR, in any case.

Originally posted by @andrewazores in #503 (comment)

@andrewazores andrewazores added the feat New feature or request label Sep 19, 2022
@tthvo tthvo added the good first issue Good for newcomers label May 16, 2023
@tthvo
Copy link
Member

tthvo commented Sep 16, 2024

This and #616 are implemented after upgrades to PF5 in #1303 :D

@andrewazores
Copy link
Member Author

Done in #1303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Pushed to 2.4.0
Development

No branches or pull requests

2 participants