Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Consistent unit test framework #848

Open
1 of 6 tasks
tthvo opened this issue Feb 2, 2023 · 4 comments
Open
1 of 6 tasks

[Story] Consistent unit test framework #848

tthvo opened this issue Feb 2, 2023 · 4 comments
Labels
good first issue Good for newcomers needs-triage Needs thorough attention from code reviewers test

Comments

@tthvo
Copy link
Member

tthvo commented Feb 2, 2023

Describe the feature

Right now, our unit framework needs refactoring to be more consistent the way we extract elements. With this, we can also move localization step into a single place.

Some new test setups also need documenting. For example, test with different screen sizes, test with a specific locale, etc.

Tasks

@tthvo tthvo added feat New feature or request needs-triage Needs thorough attention from code reviewers good first issue Good for newcomers test and removed feat New feature or request labels Feb 2, 2023
@tthvo tthvo moved this to Stretch Goals in 2.3.0 release Feb 2, 2023
@tthvo tthvo removed the status in 2.3.0 release Feb 2, 2023
@andrewazores andrewazores moved this to Stretch Goals in 2.3.0 release Feb 7, 2023
@tthvo
Copy link
Member Author

tthvo commented Mar 15, 2023

This looks like it could help us with visual testing. Storybook is actually also included as a dev deps when creating project with PF seed.

https://storybook.js.org/tutorials/visual-testing-handbook/react/en/workflow/

@andrewazores
Copy link
Member

Storybook is actually also included as a dev deps when creating project with PF seed.

Indeed:

#143

We can bring it back if we're actually going to start using it.

@tthvo
Copy link
Member Author

tthvo commented Mar 21, 2023

Adding here as a note for future work:

#914 (comment)

@tthvo
Copy link
Member Author

tthvo commented Apr 3, 2023

@andrewazores andrewazores moved this from Stretch Goals to Pushed to 2.4.0 in 2.3.0 release Apr 6, 2023
@tthvo tthvo moved this to Backlog in 2.4.0 release Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers needs-triage Needs thorough attention from code reviewers test
Projects
No open projects
Status: Pushed to 2.4.0
Status: Backlog
Development

No branches or pull requests

2 participants