-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Story] Consistent unit test framework #848
Comments
This looks like it could help us with visual testing. Storybook is actually also included as a dev deps when creating project with PF seed. https://storybook.js.org/tutorials/visual-testing-handbook/react/en/workflow/ |
Indeed: We can bring it back if we're actually going to start using it. |
Adding here as a note for future work: |
Describe the feature
Right now, our unit framework needs refactoring to be more consistent the way we extract elements. With this, we can also move localization step into a single place.
Some new test setups also need documenting. For example, test with different screen sizes, test with a specific locale, etc.
Tasks
Common.tsx
.can't update on unmounted component
warnings. Mostly relating<Select />
component.The text was updated successfully, but these errors were encountered: