Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Handle "no target" selection on Dashboard #883

Open
Tracked by #468
andrewazores opened this issue Feb 16, 2023 · 2 comments
Open
Tracked by #468

[Task] Handle "no target" selection on Dashboard #883

andrewazores opened this issue Feb 16, 2023 · 2 comments
Labels
feat New feature or request good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

          I say "at least for now" because we should probably actually handle the `NO_TARGET` selection case nicely and allow the dashboard to be created and a skeleton or empty state version of it rendered when the user hasn't selected any target. But even after we have that I think that starting a recording should still be an explicit opt-in action.

Originally posted by @andrewazores in #862 (comment)

@andrewazores andrewazores added the feat New feature or request label Apr 6, 2023
@andrewazores andrewazores added the good first issue Good for newcomers label Apr 13, 2023
@andrewazores
Copy link
Member Author

With the latest changes to the Dashboard and the target selection, this empty view state is only reachable:

  1. when the web-client is first opened and no target has ever been selected,
  2. when the previously selected target is no longer available (including the case where there are no targets at all)

There is no more ability to explicitly select "no target" and see the empty state. Maybe this doesn't need any additional handling at this point.

@tthvo
Copy link
Member

tthvo commented Sep 16, 2024

Done in #1303? Editted: Nope, this is about skeleton view when no target is selected. Though, we do have options to clear target selection now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Pushed to 2.4.0
Status: Stretch Goals
Development

No branches or pull requests

2 participants