Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Reuse target details component in matchExpression views #912

Closed
Tracked by #376
andrewazores opened this issue Mar 20, 2023 · 3 comments · Fixed by #914
Closed
Tracked by #376

[Task] Reuse target details component in matchExpression views #912

andrewazores opened this issue Mar 20, 2023 · 3 comments · Fixed by #914
Assignees
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

The right sidebar panel component here:

image

represents the same information as the right side split component here:

image

This second old-style serialized JSON component is currently present on the Automated Rules > Create and Security > Store JMX Credentials > Add views. The new details component is much more pleasing to look at and probably makes it easier for the user to differentiate the different fields they're looking at. With some section renaming or tooltips, the field names required to build a matchExpression can be determined from the new details component pretty easily.

@tthvo
Copy link
Member

tthvo commented Mar 20, 2023

With some section renaming or tooltips, the field names required to build a matchExpression can be determined from the new details component pretty easily.

Are we putting the field name into the tooltip?

Also, do we still need to keep the codeblock for hints? This is what I have right now:

Screenshot from 2023-03-20 04-54-10

@tthvo tthvo self-assigned this Mar 20, 2023
@andrewazores
Copy link
Member Author

Are we putting the field name into the tooltip?

I think so, maybe something like the JSON path, ex. target.connectUrl as the tooltip on "Connection URL". Or even just replace the "connection URL" section title with target.connectUrl.

Also, do we still need to keep the codeblock for hints? This is what I have right now:

Not necessarily, though I think it's useful to provide a hint of some form somewhere. After #913 it's hopefully self-evident and easy enough that the hint block can be removed.

@tthvo
Copy link
Member

tthvo commented Mar 20, 2023

Make sense thanks! I will add them in in the popover content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants