Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Replace HTML-based Automated Analysis Report with JSON-backed component #949

Closed
andrewazores opened this issue Apr 13, 2023 · 2 comments
Assignees
Labels
feat New feature or request good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

There are now two different visualizations for the Automated Analysis data. The original/legacy component that uses an HTML+JS+css document rendered into an iframe directly as produced by some JMC code via cryostat-core, and the new component visible on the Dashboard which uses the same JMC code to produce a JSON representation of the data and then renders this with Patternfly/React components.

The original component should be deleted from the codebase, since it has far fewer features than our new component (filtering, searching, etc.) and also has challenges around layout and applying styling (theming and accessibility).

We should also reconsider how to offer the Automated Analysis Report to the user. Now that this is available on the Dashboard, does it still make sense to expose it within the Recordings tables? If so, there must be a better way than hiding it in a collapsed table row.

@tthvo
Copy link
Member

tthvo commented Oct 6, 2023

This is completed right? #1117

@andrewazores
Copy link
Member Author

Yes, I think so. There could be more work to do to further enhance the Dashboard version of the components or to bring more of those features to the recording table row embedded version, but that can/should be tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants