Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): remove unnecessary dependencies #1086

Merged
merged 1 commit into from
Aug 14, 2023
Merged

build(deps): remove unnecessary dependencies #1086

merged 1 commit into from
Aug 14, 2023
+88 −342

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 14, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #726
Related to patternfly/patternfly-react-seed#150

Description of the change:

Removed unncessary dependencies and resolves yarn package resolution conflicts.

$ yarn install --immutable
➤ YN0000: ┌ Resolution step
➤ YN0060: │ cryostat-web@workspace:. provides react (p88e06) with version 17.0.2, which doesn't satisfy what @patternfly/react-topology and some of its descendants request
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 251ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 368ms
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed in 0s 374ms
➤ YN0000: Done with warnings in 1s 119ms

The topology package is still depending on some transitive deps that requires React 16. We might have to wait till we can safely upgrade topology package before resolving all yarn conflicts.

$ yarn explain peer-requirements p88e06
➤ YN0000: cryostat-web@workspace:. provides react@npm:17.0.2 with version 17.0.2, which doesn't satisfy the following requirements:

➤ YN0000: @patternfly/react-topology@npm:4.91.27 [af275] → ^16.8 || ^17 || ^18       ✓
➤ YN0000: mobx-react-lite@npm:2.2.2 [ebab1]              → ^16.8.0                   ✘
➤ YN0000: mobx-react@npm:6.3.1 [89258]                   → ^16.8.0 || 16.9.0-alpha.0 ✘
➤ YN0000: react-measure@npm:2.5.2 [89258]                → >0.13.0                   ✓

Motivation for the change:

Changes keep web client updated with the base patternfly seed and also removes the need for maintaining dep upgrades for ones that are not used.

@tthvo tthvo added chore Refactor, rename, cleanup, etc. build labels Aug 14, 2023
@tthvo tthvo requested review from aali309 and maxcao13 August 14, 2023 18:07
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Aug 14, 2023
@mergify mergify bot added the safe-to-test label Aug 14, 2023
@tthvo tthvo removed the needs-triage Needs thorough attention from code reviewers label Aug 14, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1086-14abdb16366f696fdebce2ae8b2c9f2d07d5190e sh smoketest.sh

@andrewazores andrewazores merged commit 8b8de35 into cryostatio:main Aug 14, 2023
27 of 34 checks passed
@tthvo tthvo deleted the update-deps branch August 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@aali309 aali309 Awaiting requested review from aali309

@maxcao13 maxcao13 Awaiting requested review from maxcao13

@ebaron ebaron Awaiting requested review from ebaron

Assignees
No one assigned
Labels
build chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores