Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build_test): fix typo #155

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Nov 9, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


related: #123

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link

github-actions bot commented Nov 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@aali309
Copy link
Contributor Author

aali309 commented Nov 9, 2023

/build_test

Copy link

github-actions bot commented Nov 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores
Copy link
Member

I think the PR will just end up running the workflow as it is defined in main, so adding changes on top of workflows here won't work for testing them. You'd have to apply them to your fork's main to see. But that typo fix looks like it's probably the whole fix.

@aali309
Copy link
Contributor Author

aali309 commented Nov 9, 2023

I think the PR will just end up running the workflow as it is defined in main, so adding changes on top of workflows here won't work for testing them. You'd have to apply them to your fork's main to see. But that typo fix looks like it's probably the whole fix.

Yes. the fix looks good, are we looking to merge this PR or you will reopen the original PR that caused this?

@andrewazores andrewazores changed the title feat(ci): testing run ci(build_test): fix typo Nov 9, 2023
@andrewazores andrewazores merged commit 9997cb2 into cryostatio:main Nov 9, 2023
10 checks passed
@aali309 aali309 deleted the testingSkippedWorkflows branch November 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants