Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] "Archive on Stop" for -XX:StartFlightRecording #253

Open
andrewazores opened this issue Jan 22, 2024 · 1 comment
Open

[Request] "Archive on Stop" for -XX:StartFlightRecording #253

andrewazores opened this issue Jan 22, 2024 · 1 comment
Labels
feat New feature or request needs-triage Needs thorough attention from code reviewers

Comments

@andrewazores
Copy link
Member

Describe the feature

See #252 and #71. When Cryostat detects a new target and observes that there are already running recordings on that target which Cryostat did not already know about (this requires knowing that this is really a new target, not an alias to an existing one), it should not only check if these recordings are fixed-duration and set timer events to update its own database at the expected duration, but it should also set up an event handler for an "archive on stop" the same way that can be done for recordings started by Cryostat itself.

There should also be a configuration option on Cryostat to enable or disable this "archive on stop externally-started recordings" feature, but we should probably default to turning it on.

Anything other information?

No response

@andrewazores andrewazores added feat New feature or request needs-triage Needs thorough attention from code reviewers labels Jan 22, 2024
@andrewazores
Copy link
Member Author

andrewazores commented Feb 8, 2024

Another thought: we don't have any mechanism for getting notified if a remote recording is stopped. We could probably do that over remote JMX by listening for notifications from the FlightRecorderMXBean but we have no equivalent for the Cryostat Agent. It would be nice to have something like this, so that if there is a remote recording that we discover, we can also perform archive-on-stop if a fixed duration recording is stopped early, or if we observe a continuous remote recording and the user manually stops it (or some other process stops it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request needs-triage Needs thorough attention from code reviewers
Projects
Status: Backlog
Status: Stretch Goals
Development

No branches or pull requests

1 participant