Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] JMX connection failures due to auth result in HTTP 504, not HTTP 427 #438

Closed
andrewazores opened this issue May 6, 2024 · 2 comments · Fixed by #439
Closed

[Bug] JMX connection failures due to auth result in HTTP 504, not HTTP 427 #438

andrewazores opened this issue May 6, 2024 · 2 comments · Fixed by #439
Assignees
Labels
bug Something isn't working high-priority

Comments

@andrewazores
Copy link
Member

Current Behavior

See #350

When attempting to connect to a target using JMX authentication, and when Cryostat does not have any corresponding stored credentials, Cryostat should fail the connection and respond to the client with an HTTP 427.

Expected Behavior

Cryostat instead takes some time and then responds with HTTP 504.

Steps To Reproduce

  1. ./smoketest.bash -t
  2. Select the vertx-fib-demo-2:9094 target, which uses JMX auth
  3. Go to Events view to try to view event templates

Environment

No response

Anything else?

No response

@andrewazores andrewazores added bug Something isn't working high-priority labels May 6, 2024
@andrewazores andrewazores self-assigned this May 6, 2024
@andrewazores
Copy link
Member Author

Bisect shows that this started with #424

@andrewazores
Copy link
Member Author

Looks like it just comes down to:

diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
index adef239..67b8e7f 100644
--- a/src/main/resources/application.properties
+++ b/src/main/resources/application.properties
@@ -1,3 +1,4 @@
+quarkus.naming.enable-jndi=true
 cryostat.discovery.jdp.enabled=false
 cryostat.discovery.containers.poll-period=10s
 cryostat.discovery.containers.request-timeout=2s

Not even sure why that got into the PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant