Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Pending decision on adding feemarket module to chain-main #758

Open
devashishdxt opened this issue Apr 27, 2022 · 5 comments
Open
Assignees

Comments

@devashishdxt
Copy link
Collaborator

This issue is to discuss about the feemarket module and add it to chain-main if needed as suggested by @yihuang.

@yihuang
Copy link
Collaborator

yihuang commented Apr 27, 2022

cosmos/cosmos-sdk#11499
the multi-tier design implementation, which can work on cosmos-sdk 0.46
the multi-tier design adr: cosmos/cosmos-sdk#10653

@tomtau
Copy link
Contributor

tomtau commented Apr 27, 2022

good to be added, but the multi-tier one won't work until ABCI++ changes, right?

@yihuang
Copy link
Collaborator

yihuang commented Apr 28, 2022

good to be added, but the multi-tier one won't work until ABCI++ changes, right?

The block space reservation feature would need support from tendermint, I'm not sure if it's possible even with abci++, @JayT106 what do you think on this one?
other than that, it's just a consensus fee and tx prioritization strategy, the outcome should be similar to eip-1559 in general, the eip-1559 is like a multi-tier system with many fine grained tiers which has same fee adjustment speeds.

@yihuang
Copy link
Collaborator

yihuang commented Apr 28, 2022

But without the block space reservation, it seems vulnerable to certain attack where one saturate block space with low tier txs to push up the price of higher tier tx whose price adjust at a faster speed. but one don't have direct incentives to do these kind of attacks though.

@JayT106
Copy link
Contributor

JayT106 commented May 30, 2022

The abci++ indeed cannot solve the low tx fee tier squeezed issue. For the block space reservation feature, the Tendermint dev team may not want to implement this. The different apps will want different block proposing strategies I think.

And from the validator's perspective, the high processing fee makes more incentive to be a validator.

If App/Consensus protocol tx throughput can be improved, the block space reservation might not be that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@yihuang @tomtau @JayT106 @devashishdxt and others