Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT license text missing #514

Closed
djmdjm opened this issue Aug 19, 2024 · 4 comments · Fixed by #516
Closed

MIT license text missing #514

djmdjm opened this issue Aug 19, 2024 · 4 comments · Fixed by #516

Comments

@djmdjm
Copy link
Contributor

djmdjm commented Aug 19, 2024

Quite a few of the files are listed as being dual-licensed under both the MIT and Apache 2.0 licenses, but the LICENSE file in the root of the repository only contains text for the Apache license. Would it be possible to include explicit MIT license text? Either in the LICENSE file as a separate section or in a separate file (say LICENSE.MIT) would be fine.

Context: we're considering using the ML-KEM implementation from libcrux in OpenSSH and we'd like to use avail ourselves of the option to use it under the MIT license.

@franziskuskiefer
Copy link
Member

I add the MIT license file in #516.
Do you plan on using the Rust version or the C extraction?

@djmdjm
Copy link
Contributor Author

djmdjm commented Aug 20, 2024

Thanks for the fast response! We'd be interested in using the C extraction.

@franziskuskiefer
Copy link
Member

👍🏻 There are currently two different versions in the tree.

  • The c directory contains a full C version with all variants
  • The cg directory contains 768 in a header only configuration

There is also a Neon implementation that is currently not extracted. I'd be happy to discuss help you extract other variants/combinations if needed.

@djmdjm
Copy link
Contributor Author

djmdjm commented Aug 20, 2024

Thanks! I sent you an email to discuss further because the issue tracker probably isn't the best place to talk...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants